netdev - RE: [PATCH] qlcnic - Fix scheduling while atomic bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <E31FB011129F30488D5861F38390491520D4F86604@BLRX7MCDC201.AMER.DELL.COM>
Date:	Fri, 28 Sep 2012 13:08:51 +0530
From:	<Narendra_K@...l.com>
To:	<davem@...emloft.net>
CC:	<netdev@...r.kernel.org>, <sony.chacko@...gic.com>,
	<jitendra.kalsaria@...gic.com>, <john.r.fastabend@...el.com>
Subject: RE: [PATCH] qlcnic - Fix scheduling while atomic bug

> -----Original Message-----
> From: netdev-owner@...r.kernel.org [mailto:netdev-
> owner@...r.kernel.org] On Behalf Of David Miller
> Sent: Friday, September 28, 2012 4:56 AM
> To: K, Narendra
> Cc: netdev@...r.kernel.org; sony.chacko@...gic.com;
> jitendra.kalsaria@...gic.com; john.r.fastabend@...el.com
> Subject: Re: [PATCH] qlcnic - Fix scheduling while atomic bug
> 
> From: <Narendra_K@...l.com>
> Date: Tue, 25 Sep 2012 10:53:19 -0700
> 
> > From: Narendra K <narendra_k@...l.com>
> >
> > In the device close path, 'qlcnic_fw_destroy_ctx' and
> > 'qlcnic_poll_rsp' call msleep. But  'qlcnic_fw_destroy_ctx' and
> > 'qlcnic_poll_rsp' are called with 'adapter->tx_clean_lock' spin lock
> > held resulting in scheduling while atomic bug causing the following
> > trace.
> >
> > I observed that the commit 012dc19a45b2b9cc2ebd14aaa401cf782c2abba4
> > from John Fastabend addresses a similar issue in ixgbevf driver.
> > Adopting the same approach used in the commit, this patch uses mdelay
> > to address the issue.
>  ...
> > Signed-off-by: Narendra K <narendra_k@...l.com>
> 
> Applied, thanks.
> 
> In the future please format your Subject lines for patches as
> "subsytem: Description."  instead of this "subsystem - Description."
> layout.

Hi David, thank you for reviewing and applying the patch. I will follow the suggested layout for future submissions.

Hi Jitendra, thank you for reviewing the patch.
 
With regards,
Narendra K
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html