netdev - Re: [net-next PATCH 3/4] be2net: cleanup code related to be_link_status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120930.021616.2300886737245762860.davem@davemloft.net>
Date:	Sun, 30 Sep 2012 02:16:16 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	sathya.perla@...lex.com
Cc:	netdev@...r.kernel.org
Subject: Re: [net-next PATCH 3/4] be2net: cleanup code related to
 be_link_status_query()

From: Sathya Perla <sathya.perla@...lex.com>
Date: Fri, 28 Sep 2012 20:09:43 +0530

> 1) link_status_query() is always called to query the link-speed (speed
> after applying qos). When there is no qos setting, link-speed is derived from
> port-speed. Do all this inside this routine and hide this from the callers.
> 
> 2) adpater->phy.forced_port_speed is not being set anywhere after being
> initialized. Get rid of this variable.
> 
> 3) Ignore async link_speed notifications till the initial value has been
> fetched from FW.
> 
> Signed-off-by: Sathya Perla <sathya.perla@...lex.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html