netdev - Re: [PATCH net] use skb_end_offset() in skb_try

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1349112517.12401.715.camel@edumazet-glaptop>
Date:	Mon, 01 Oct 2012 19:28:37 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Weiping Pan <wpan@...hat.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] use skb_end_offset() in skb_try_coalesce()

On Sat, 2012-09-29 at 14:15 +0800, Weiping Pan wrote:
> Commit ec47ea824774(skb: Add inline helper for getting the skb end offset from
> head) introduces this helper function, skb_end_offset(),
> we should make use of it.
> 
> Signed-off-by: Weiping Pan <wpan@...hat.com>
> ---
>  net/core/skbuff.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/net/core/skbuff.c b/net/core/skbuff.c
> index e33ebae..86f040a 100644
> --- a/net/core/skbuff.c
> +++ b/net/core/skbuff.c
> @@ -3488,8 +3488,7 @@ bool skb_try_coalesce(struct sk_buff *to, struct sk_buff *from,
>  		    skb_shinfo(from)->nr_frags > MAX_SKB_FRAGS)
>  			return false;
>  
> -		delta = from->truesize -
> -			SKB_TRUESIZE(skb_end_pointer(from) - from->head);
> +		delta = from->truesize - SKB_TRUESIZE(skb_end_offset(from));
>  	}
>  
>  	WARN_ON_ONCE(delta < len);

Acked-by: Eric Dumazet <edumazet@...gle.com>



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html