netdev - Re: [RFC PATCH] ipv6: don't add link local route when there is no link local address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20121001.165527.1025640918619977740.davem@davemloft.net>
Date:	Mon, 01 Oct 2012 16:55:27 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	nicolas.dichtel@...nd.com
Cc:	netdev@...r.kernel.org, yoshfuji@...ux-ipv6.org
Subject: Re: [RFC PATCH] ipv6: don't add link local route when there is no
 link local address

From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
Date: Wed, 26 Sep 2012 15:09:22 +0200

> When an address is added on loopback (ip -6 a a 2002::1/128 dev lo), a route
> to fe80::/64 is added in the main table:
>   unreachable fe80::/64 dev lo  proto kernel  metric 256  error -101
> 
> This route does not match any prefix (no fe80:: address on lo). In fact,
> addrconf_dev_config() will not add link local address because this function
> filters interfaces by type. If the link local address is added manually, the
> route to the link local prefix will be automatically added by
> addrconf_add_linklocal().
> Note also, that this route is not deleted when the address is removed.
> 
> After looking at the code, it seems that addrconf_add_lroute() is redundant with
> addrconf_add_linklocal(), because this function will add the link local route
> when the link local address is configured.
> 
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>

This change looks correct, however:

> @@ -2489,7 +2479,6 @@ static void addrconf_sit_config(struct net_device *dev)
>  
>  	if (dev->flags&IFF_POINTOPOINT) {
>  		addrconf_add_mroute(dev);
> -		addrconf_add_lroute(dev);
>  	} else
>  		sit_route_add(dev);

now that the if() branch is a single statement, please remove the
curly braces.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html