netdev - Re: [PATCH net-next] mlx4: dont orphan skbs in mlx4_en

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20121001.170305.1749278118378383172.davem@davemloft.net>
Date:	Mon, 01 Oct 2012 17:03:05 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	yevgenyp@...lanox.com, netdev@...r.kernel.org,
	ogerlitz@...lanox.com
Subject: Re: [PATCH net-next] mlx4: dont orphan skbs in mlx4_en_xmit()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 28 Sep 2012 19:53:26 +0200

> From: Eric Dumazet <edumazet@...gle.com>
> 
> After commit e22979d96a55d (mlx4_en: Moving to Interrupts for TX
> completions) we no longer need to orphan skbs in mlx4_en_xmit()
> since skb wont stay a long time in TX ring before their release.
> 
> Orphaning skbs in ndo_start_xmit() should be avoided as much as
> possible, since it breaks TCP Small Queue or other flow control
> mechanisms (per socket limits)
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html