netdev - Re: [PATCH v2] iproute2: add support for tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1349213229.12401.1130.camel@edumazet-glaptop>
Date:	Tue, 02 Oct 2012 23:27:09 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Julian Anastasov <ja@....bg>
Cc:	Stephen Hemminger <shemminger@...tta.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v2] iproute2: add support for tcp_metrics

On Tue, 2012-10-02 at 23:04 +0200, Eric Dumazet wrote:
> On Tue, 2012-10-02 at 23:45 +0300, Julian Anastasov wrote:
> > 	ip tcp_metrics/tcpmetrics
> > 
> > 	We support get/del for single entry and dump for
> > show/flush.
> > 
> > Signed-off-by: Julian Anastasov <ja@....bg>
> > ---
> 
> Thanks Julian, this version works
> 
> Acked-by: Eric Dumazet <edumazet@...gle.com>

By the way, it seems kernel exports scaled srtt by 8, and rttvar by 4.

And tcp_get_info() correctly exports us, not ms.

info->tcpi_rtt = jiffies_to_usecs(tp->srtt)>>3;
info->tcpi_rttvar = jiffies_to_usecs(tp->mdev)>>2;

IMHO we should use same unit than TCP_INFO (us for these values)





--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html