netdev - RE: [PATCH 3/3] net/mlx4_en: Add HW timestamping (TS) support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <953B660C027164448AE903364AC447D287224734@MTLDAG01.mtl.com>
Date:	Tue, 2 Oct 2012 07:32:17 +0000
From:	Yevgeny Petrilin <yevgenyp@...lanox.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Eugenia Emantayev <eugenia@...lanox.com>
Subject: RE: [PATCH 3/3] net/mlx4_en: Add HW timestamping (TS) support

> > +
> > +	if (rx_filter != HWTSTAMP_FILTER_NONE)
> > +		dev->features &= ~NETIF_F_HW_VLAN_RX;
> > +	else
> > +		dev->features |= NETIF_F_HW_VLAN_RX;
> [...]
> 
> If you change dev->features you should also call
> netdev_features_change(dev) (holding only the RTNL lock, so after you
> unlock mdev->state_lock).
> 
> Ben.
> 
Thanks Ben,
Will fix.

Yevgeny