lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 3 Oct 2012 12:46:52 +0200
From:	Jesper Nilsson <jesper.nilsson@...s.com>
To:	Fengguang Wu <fengguang.wu@...el.com>
Cc:	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: drivers/net/cris/eth_v10.c:1715:2: error: too many arguments
 to function 'e100rxtx_interrupt'

On Fri, Sep 28, 2012 at 03:06:08PM +0200, Fengguang Wu wrote:
> Hi Jesper,

Hi!

> FYI, a rather old build bug that's introduced by
> 
> bafef0a cris build fixes: update eth_v10.c ethernet driver
> 
> All error/warnings:
> 
> drivers/net/cris/eth_v10.c: In function 'e100_netpoll':
> drivers/net/cris/eth_v10.c:1715:2: error: too many arguments to function 'e100rxtx_interrupt'
> drivers/net/cris/eth_v10.c:1131:1: note: declared here

Yep, I can't figure out why the followup patches never reached mainline,
but we have fixes for exactly that in our in-house tree.
I'll push some move patches after this merge window.

> vim +1715 drivers/net/cris/eth_v10.c
> 
> ^1da177e (Linus Torvalds 2005-04-16  1710) 
> bafef0ae (Jesper Nilsson 2007-11-14  1711) #ifdef CONFIG_NET_POLL_CONTROLLER
> bafef0ae (Jesper Nilsson 2007-11-14  1712) static void
> bafef0ae (Jesper Nilsson 2007-11-14  1713) e100_netpoll(struct net_device* netdev)
> bafef0ae (Jesper Nilsson 2007-11-14  1714) {
> bafef0ae (Jesper Nilsson 2007-11-14 @1715) 	e100rxtx_interrupt(NETWORK_DMA_TX_IRQ_NBR, netdev, NULL);
> bafef0ae (Jesper Nilsson 2007-11-14  1716) }
> bafef0ae (Jesper Nilsson 2007-11-14  1717) #endif
> bafef0ae (Jesper Nilsson 2007-11-14  1718) 
> ^1da177e (Linus Torvalds 2005-04-16  1719) static int
> ^1da177e (Linus Torvalds 2005-04-16  1720) etrax_init_module(void)
> ^1da177e (Linus Torvalds 2005-04-16  1721) {
> ^1da177e (Linus Torvalds 2005-04-16  1722) 	return etrax_ethernet_init();
> ^1da177e (Linus Torvalds 2005-04-16  1723) }

Thanks!

/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- jesper.nilsson@...s.com
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists