netdev - Re: [PATCH] net: sunrpc: xdr: Change message to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201210041625.23710.marex@denx.de>
Date:	Thu, 4 Oct 2012 16:25:23 +0200
From:	Marek Vasut <marex@...x.de>
To:	Fabio Estevam <fabio.estevam@...escale.com>
Cc:	davem@...emloft.net, Trond.Myklebust@...app.com,
	netdev@...r.kernel.org, linux-nfs@...r.kernel.org
Subject: Re: [PATCH] net: sunrpc: xdr: Change message to pr_debug level

Dear Fabio Estevam,

> commit 49f6189 (SUNRPC: Optimise away unnecessary data moves in
> xdr_align_pages) has added a pr_info that floods dmesg when booting via
> NFS.
> 
> There is also a note in the commit log: "Warning! Contains debugging
> printks!"
> 
> ,so change it to pr_debug instead.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>

Reviewed-by: Marek Vasut <marex@...x.de>

> ---
>  net/sunrpc/xdr.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c
> index e30842b..6983efc 100644
> --- a/net/sunrpc/xdr.c
> +++ b/net/sunrpc/xdr.c
> @@ -749,7 +749,7 @@ static unsigned int xdr_align_pages(struct xdr_stream
> *xdr, unsigned int len) xdr_shrink_pagelen(buf, buf->page_len - len);
>  		xdr->nwords = XDR_QUADLEN(buf->len - cur);
>  	} else
> -		pr_info("%s: Optimised away a data move!\n", __func__);
> +		pr_debug("%s: Optimised away a data move!\n", __func__);
>  	return len;
>  }

Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html