lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 05 Oct 2012 07:54:33 +0200 From: Michal Simek <monstr@...str.eu> To: Ben Hutchings <bhutchings@...arflare.com> CC: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Anirudha Sarangi <anirudh@...inx.com>, John Linn <John.Linn@...inx.com>, Grant Likely <grant.likely@...retlab.ca>, Rob Herring <rob.herring@...xeda.com>, "David S. Miller" <davem@...emloft.net> Subject: Re: [PATCH 02/11] net: axienet: Add ioctl support On 10/04/2012 09:17 PM, Ben Hutchings wrote: > On Thu, 2012-10-04 at 20:14 +0200, Michal Simek wrote: >> Allow user to access the MDIO from userspace. >> >> Signed-off-by: Michal Simek <monstr@...str.eu> >> CC: Anirudha Sarangi <anirudh@...inx.com> >> CC: John Linn <John.Linn@...inx.com> >> CC: Grant Likely <grant.likely@...retlab.ca> >> CC: Rob Herring <rob.herring@...xeda.com> >> CC: David S. Miller <davem@...emloft.net> >> --- >> drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 15 +++++++++++++++ >> 1 files changed, 15 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c >> index 50167ab..a5b41cd 100644 >> --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c >> +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c >> @@ -1053,6 +1053,20 @@ static void axienet_poll_controller(struct net_device *ndev) >> } >> #endif >> >> +/* Ioctl MII Interface */ >> +static int axienet_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) >> +{ >> + struct axienet_local *priv = netdev_priv(dev); >> + >> + if (!netif_running(dev)) >> + return -EINVAL; > > Not sure this is the appropriate error code. > >> + if (!priv->phy_dev) >> + return -ENODEV; > > Error code should be EOPNOTSUPP - the device is present but just doesn't > support MDIO. ok. Thanks will fix it. Thanks, Michal -- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ Microblaze U-BOOT custodian -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists