netdev - Re: [net:master 1/9] pch_gbe_main.c:(.text+0x510370): undefined reference to `pch_ch_control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20121006.092253.266767529000849292.davem@davemloft.net>
Date:	Sat, 06 Oct 2012 09:22:53 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	romieu@...zoreil.com
Cc:	fengguang.wu@...el.com, netdev@...r.kernel.org,
	haicheng.li@...ux.intel.com, ben@...adent.org.uk
Subject: Re: [net:master 1/9] pch_gbe_main.c:(.text+0x510370): undefined
 reference to `pch_ch_control_write'

From: Francois Romieu <romieu@...zoreil.com>
Date: Sat, 6 Oct 2012 13:31:26 +0200

> Fengguang Wu <fengguang.wu@...el.com> :
> [...]
>> FYI, kernel build failed on
>> 
>> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master
>> head:   c0b8b99287235626a5850ef7e5bfc842d1ebcecd
>> commit: da1586461e53a4dd045738cce309ab488970f0ef [1/9] pch_gbe: Fix PTP dependencies.
>> config: x86_64-randconfig-s052 (attached as .config)
> 
> 7c236c43b838221e17220bcb39e8e8d8c7123713 does something like the patch
> below for the sfc driver. It would be worth checking if gianfar and
> intel get it right too.

They use select and it should work here too, I don't want to
force users to have to know about an obscure PTP chip type
in order to enable PTP for their networking card.

It should be completely hidden from them.

That's why we should use select for this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html