netdev - Re: [patch v4 1/2] netlink: add reference of module in netlink_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20121007.003117.530528242235438911.davem@davemloft.net>
Date:	Sun, 07 Oct 2012 00:31:17 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	gaofeng@...fujitsu.com
Cc:	eric.dumazet@...il.com, steffen.klassert@...unet.com,
	pablo@...filter.org, netdev@...r.kernel.org,
	linux-rdma@...r.kernel.org, stephen.hemminger@...tta.com,
	jengelh@...i.de
Subject: Re: [patch v4 1/2] netlink: add reference of module in
 netlink_dump_start

From: Gao feng <gaofeng@...fujitsu.com>
Date: Fri, 5 Oct 2012 14:15:48 +0800

> I get a panic when I use ss -a and rmmod inet_diag at the
> same time.
> 
> it's because netlink_dump use inet_diag_dump witch function
> belongs to module inet_diag.
> 
> I search the codes and find many modules have the same problem.
> We need add reference of the module which the cb->dump belongs
> to.
> 
> Thanks for all help from Stephen,Jan,Eric,Steffen and Pablo.
> 
> Change From v3:
> change netlink_dump_start to inline,suggestion from Pablo and
> Eric.
> 
> Change From v2:
> delete netlink_dump_done,and call module_put in netlink_dump
> and netlink_sock_destruct.
> 
> Signed-off-by: Gao feng <gaofeng@...fujitsu.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html