netdev - Re: [PATCH] net: remove skb recycling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20121007.004109.1308709793907808073.davem@davemloft.net>
Date:	Sun, 07 Oct 2012 00:41:09 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	mbizon@...ebox.fr, david+ml@...ore.org, romieu@...zoreil.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] net: remove skb recycling

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 05 Oct 2012 18:23:55 +0200

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Over time, skb recycling infrastructure got litle interest and
> many bugs. Generic rx path skb allocation is now using page
> fragments for efficient GRO / TCP coalescing, and recyling
> a tx skb for rx path is not worth the pain.
> 
> Last identified bug is that fat skbs can be recycled
> and it can endup using high order pages after few iterations.
> 
> With help from Maxime Bizon, who pointed out that commit
> 87151b8689d (net: allow pskb_expand_head() to get maximum tailroom)
> introduced this regression for recycled skbs.
> 
> Instead of fixing this bug, lets remove skb recycling.
> 
> Drivers wanting really hot skbs should use build_skb() anyway,
> to allocate/populate sk_buff right before netif_receive_skb()
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Maxime Bizon <mbizon@...ebox.fr>

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html