netdev - Re: [PATCH v4] skge: Add DMA mask quirk for Marvell 88E8001 on ASUS P5NSLI motherboard.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20121008.030707.864754447318232909.davem@davemloft.net>
Date:	Mon, 08 Oct 2012 03:07:07 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	graham.gower@...il.com
Cc:	netdev@...r.kernel.org, shemminger@...tta.com
Subject: Re: [PATCH v4] skge: Add DMA mask quirk for Marvell 88E8001 on
 ASUS P5NSLI motherboard.

From: Graham Gower <graham.gower@...il.com>
Date: Mon, 08 Oct 2012 17:13:24 +1030

> Marvell 88E8001 on an ASUS P5NSLI motherboard is unable to
> send/receive
> packets on a system with >4gb ram unless a 32bit DMA mask is used.

Please format this ascii text properly.  WHy is there a line
with just two words surrounded by full nearly 80-column lines?

> +		.matches = {
> + DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),

THis is still formatted incorrectly, it's actually in the file
not due to your email client.

Can you indent the thing properly, please?

This is V4 of this patch, and suffering purely from first order coding
style and procedural stuff.  As you can imagine, it's very frustrating
to have to spend this much time getting such simple things taken care
of.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html