netdev - Re: skge: Add DMA mask quirk for Marvell 88E8001 on ASUS P5NSLI motherboard.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121008091608.0b03befa@nehalam.linuxnetplumber.net>
Date:	Mon, 8 Oct 2012 09:16:08 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Graham Gower <graham.gower@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: skge: Add DMA mask quirk for Marvell 88E8001 on ASUS P5NSLI
 motherboard.

On Sun, 07 Oct 2012 16:25:45 +1030
Graham Gower <graham.gower@...il.com> wrote:

> Marvell 88E8001 on an ASUS P5NSLI motherboard is unable to send/receive
> packets on a system with >4gb ram unless a 32bit DMA mask is used.
> 
> This issue has been around for years and a fix was sent 3.5 years ago, but
> there was some debate as to whether it should instead be fixed as a PCI quirk.
> http://www.spinics.net/lists/netdev/msg88670.html
> 
> However, 18 months later a similar workaround was introduced for another
> chipset exhibiting the same problem.
> http://www.spinics.net/lists/netdev/msg142287.html
> 
> Signed-off-by: Graham Gower <graham.gower@...il.com>
> 
> --- skge.c.bak	2012-10-07 13:00:56.000000000 +1030
> +++ skge.c	2012-10-07 13:26:03.000000000 +1030
> @@ -4143,6 +4143,13 @@
>   			DMI_MATCH(DMI_BOARD_NAME, "nForce"),
>   		},
>   	},
> +	{
> +		.ident = "ASUS P5NSLI",
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
> +			DMI_MATCH(DMI_BOARD_NAME, "P5NSLI")
> +		},
> +	},
>   	{}
>   };
>   

This fix is fine, but like Jan said it needs to be based at the
right place in the filesystem tree for inclusion.

I wonder if it would be a good idea to add a way to automatically
check for this quirk using the debug registers on the chip which allow
peeking. Using the test registers B3_RAM_DATA_LO/B3_RAM_DATA_HI.

The problem is that might introduce worse problems if it causes
DMA access to non-existent memory and trying to recover from the fault.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html