netdev - Re: [PATCH] net/ethernet/jme: disable ASPM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20121008.152426.1524908667081347879.davem@davemloft.net>
Date:	Mon, 08 Oct 2012 15:24:26 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	kevin.baradon@...il.com
Cc:	cooldavid@...ldavid.org, mjg@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net/ethernet/jme: disable ASPM

From: Kevin Baradon <kevin.baradon@...il.com>
Date: Mon,  8 Oct 2012 21:02:36 +0200

> Based on patch from Matthew Garrett <mjg@...hat.com> (https://lkml.org/lkml/2011/11/11/168).
> 
> http://driveragent.com/archive/30421/7-0-14 indicates that ASPM is
> disabled on the 250 and 260. Duplicate for sanity.
> 
> Fixes random RX engine hangs I experienced with JMC250 on Clevo W270HU.
> 
> Signed-off-by: Kevin Baradon <kevin.baradon@...il.com>

This should be a PCI quirk shouldn't it?

Also:

> +	pci_disable_link_state(pdev, PCIE_LINK_STATE_L0S | PCIE_LINK_STATE_L1 |
> +		PCIE_LINK_STATE_CLKPM);

This is terrible formatting, you must line up the "PCIE_LINK_STATE_CLKPM" on
the second line with the very first column after the openning parenthesis
on the first line.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html