[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 10 Oct 2012 15:58:38 +0200
From: Andreas Schwab <schwab@...ux-m68k.org>
To: Joe Perches <joe@...ches.com>
Cc: Dan Carpenter <dan.carpenter@...cle.com>,
Karsten Keil <isdn@...ux-pingi.de>,
"David S. Miller" <davem@...emloft.net>,
Masanari Iida <standby24x7@...il.com>, netdev@...r.kernel.org,
kernel-janitors@...r.kernel.org
Subject: Re: [patch] isdn: fix a wrapping bug in isdn_ppp_ioctl()
Sorry, I was misremembering the history of the bit ops. There has
historically been issues with varying bit order, but noadays set_bit is
always defined consistently with C shifts.
But another issue, set_bit is an atomic operation which may be
significantly more expensive than the equivalent C operation. Better
use __set_bit when atomicity is not needed.
Andreas.
--
Andreas Schwab, schwab@...ux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists