lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 10 Oct 2012 16:44:02 +0100 From: "David Laight" <David.Laight@...LAB.COM> To: "Joe Perches" <joe@...ches.com> Cc: "Andreas Schwab" <schwab@...ux-m68k.org>, "Dan Carpenter" <dan.carpenter@...cle.com>, "Karsten Keil" <isdn@...ux-pingi.de>, "David S. Miller" <davem@...emloft.net>, "Masanari Iida" <standby24x7@...il.com>, <netdev@...r.kernel.org>, <kernel-janitors@...r.kernel.org> Subject: RE: [patch] isdn: fix a wrapping bug in isdn_ppp_ioctl() > On Wed, 2012-10-10 at 15:59 +0100, David Laight wrote: > > Seems to me the code is expecting 256 bits of data, not any multiple of int, > > long or anything else. > > include/linux/isdn_ppp.h:#define PPPIOCGCOMPRESSORS _IOR('t',134,unsigned long [8]) That doesn't mean the whole thing makes any sense on 64bit systems. A whole load of historic code used 'long' to ensure 32bit. Some of that might have crept into Linux sources. Since I suspect there are a maximum of 256 bits on both 32 and 64bit systems, I wouldn't like to guess exactly how any particular 64bit application chooses to check the bitmap. The ioctl constant may be wrong on 64 bit systems. David -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists