netdev - Re: [PATCH] of/mdio: Staticise !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20121010.223850.1856019052308947278.davem@davemloft.net>
Date:	Wed, 10 Oct 2012 22:38:50 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	broonie@...nsource.wolfsonmicro.com
Cc:	srinivas.kandagatla@...com, fengguang.wu@...el.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] of/mdio: Staticise !CONFIG_OF stubs

From: David Miller <davem@...emloft.net>
Date: Wed, 10 Oct 2012 22:34:27 -0400 (EDT)

> From: Mark Brown <broonie@...nsource.wolfsonmicro.com>
> Date: Wed, 10 Oct 2012 13:33:38 +0900
> 
>> The !CONFIG_OF stubs aren't static so if multiple files include the
>> header with this configuration then the linker will see multiple
>> definitions of the stubs.
>> 
>> Reported-by: Fengguang Wu <fengguang.wu@...el.com>
>> Signed-off-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
> 
> Applied.

Did you actually try to compile this?

In file included from drivers/net/phy/mdio_bus.c:29:0:
include/linux/of_mdio.h:29:12: warning: ‘of_mdiobus_register’ defined but not used [-Wunused-function]
include/linux/of_mdio.h:34:27: warning: ‘of_phy_find_device’ defined but not used [-Wunused-function]
include/linux/of_mdio.h:39:27: warning: ‘of_phy_connect’ defined but not used [-Wunused-function]
include/linux/of_mdio.h:47:27: warning: ‘of_phy_connect_fixed_link’ defined but not used [-Wunused-function]
include/linux/of_mdio.h:54:24: warning: ‘of_mdio_find_bus’ defined but not used [-Wunused-function]
In file included from drivers/net/phy/mdio-gpio.c:32:0:
include/linux/of_mdio.h:34:27: warning: ‘of_phy_find_device’ defined but not used [-Wunused-function]
include/linux/of_mdio.h:39:27: warning: ‘of_phy_connect’ defined but not used [-Wunused-function]
include/linux/of_mdio.h:47:27: warning: ‘of_phy_connect_fixed_link’ defined but not used [-Wunused-function]
include/linux/of_mdio.h:54:24: warning: ‘of_mdio_find_bus’ defined but not used [-Wunused-function]

If you're going to mark this stuff static, you gotta mark that
shit inline too.

I'll fix this up, but test your changes please.