netdev - Re: [PATCH NET] e1000e: Change wthresh to 1 to avoid possible Tx stalls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20121010.230000.1520707219906312743.davem@davemloft.net>
Date:	Wed, 10 Oct 2012 23:00:00 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jesse.brandeburg@...el.com
Cc:	netdev@...r.kernel.org, shimoda.hiroaki@...il.com,
	eric.dumazet@...il.com, therbert@...gle.com
Subject: Re: [PATCH NET] e1000e: Change wthresh to 1 to avoid possible Tx
 stalls

From: Jesse Brandeburg <jesse.brandeburg@...el.com>
Date: Wed, 10 Oct 2012 18:34:20 -0700

> From: Hiroaki SHIMODA <shimoda.hiroaki@...il.com>
> 
> This patch originated from Hiroaki SHIMODA but has been modified
> by Intel with some minor cleanups and additional commit log text.
> 
> Denys Fedoryshchenko and others reported Tx stalls on e1000e with
> BQL enabled.  Issue was root caused to hardware delays. They were
> introduced because some of the e1000e hardware with transmit
> writeback bursting enabled, waits until the driver does an
> explict flush OR there are WTHRESH descriptors to write back.
> 
> Sometimes the delays in question were on the order of seconds,
> causing visible lag for ssh sessions and unacceptable tx
> completion latency, especially for BQL enabled kernels.
> 
> To avoid possible Tx stalls, change WTHRESH back to 1.
> 
> The current plan is to investigate a method for re-enabling
> WTHRESH while not harming BQL, but those patches will be later
> for net-next if they work.
> 
> please enqueue for stable since v3.3 as this bug was introduced in
> commit 3f0cfa3bc11e7f00c9994e0f469cbc0e7da7b00c
> Author: Tom Herbert <therbert@...gle.com>
> Date:   Mon Nov 28 16:33:16 2011 +0000
> 
>     e1000e: Support for byte queue limits
> 
>     Changes to e1000e to use byte queue limits.
> 
> Reported-by: Denys Fedoryshchenko <denys@...p.net.lb>
> Tested-by: Denys Fedoryshchenko <denys@...p.net.lb>
> Signed-off-by: Hiroaki SHIMODA <shimoda.hiroaki@...il.com>
> CC: eric.dumazet@...il.com
> CC: therbert@...gle.com
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html