netdev - Re: [PATCH] net dsa: add phy's interrupts management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121016080329.GI15785@wantstofly.org>
Date:	Tue, 16 Oct 2012 10:03:29 +0200
From:	Lennert Buytenhek <buytenh@...tstofly.org>
To:	Rodolfo Giometti <giometti@...ux.it>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net dsa: add phy's interrupts management

On Mon, Oct 15, 2012 at 03:33:28PM +0200, Rodolfo Giometti wrote:

> diff --git a/net/dsa/slave.c b/net/dsa/slave.c
> index 6e9e4546..817bbbd 100644
> --- a/net/dsa/slave.c
> +++ b/net/dsa/slave.c
> @@ -340,6 +340,11 @@ static const struct net_device_ops trailer_netdev_ops = {
>  };
>  #endif
>  
> +static void dsa_slave_handle_link_change(struct net_device *dev)
> +{
> +	/* nop */
> +}
> +
>  /* slave device setup *******************************************************/
>  struct net_device *
>  dsa_slave_create(struct dsa_switch *ds, struct device *parent,
> @@ -400,8 +405,8 @@ dsa_slave_create(struct dsa_switch *ds, struct device *parent,
>  	netif_carrier_off(slave_dev);
>  
>  	if (p->phy != NULL) {
> -		phy_attach(slave_dev, dev_name(&p->phy->dev),
> -			   0, PHY_INTERFACE_MODE_GMII);
> +		phy_connect_direct(p->dev, p->phy, dsa_slave_handle_link_change,
> +				0, PHY_INTERFACE_MODE_GMII);
>  
>  		p->phy->autoneg = AUTONEG_ENABLE;

What does this do?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html