netdev - RE: [PATCH 1/2] Fix build error caused by broken PCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <02874ECE860811409154E81DA85FBB5830C157F1@ORSMSX105.amr.corp.intel.com>
Date:	Tue, 16 Oct 2012 21:08:20 +0000
From:	"Keller, Jacob E" <jacob.e.keller@...el.com>
To:	David Miller <davem@...emloft.net>,
	"bhutchings@...arflare.com" <bhutchings@...arflare.com>
CC:	"richardcochran@...il.com" <richardcochran@...il.com>,
	"haicheng.li@...ux.intel.com" <haicheng.li@...ux.intel.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"tshimizu818@...il.com" <tshimizu818@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"haicheng.lee@...il.com" <haicheng.lee@...il.com>
Subject: RE: [PATCH 1/2] Fix build error caused by broken PCH_PTP module
 dependency.

> -----Original Message-----
> From: netdev-owner@...r.kernel.org [mailto:netdev-owner@...r.kernel.org]
> On Behalf Of David Miller
> Sent: Tuesday, October 16, 2012 1:17 PM
> To: bhutchings@...arflare.com
> Cc: richardcochran@...il.com; haicheng.li@...ux.intel.com;
> netdev@...r.kernel.org; tshimizu818@...il.com; linux-
> kernel@...r.kernel.org; haicheng.lee@...il.com
> Subject: Re: [PATCH 1/2] Fix build error caused by broken PCH_PTP module
> dependency.
> 
> From: Ben Hutchings <bhutchings@...arflare.com>
> Date: Tue, 16 Oct 2012 21:09:27 +0100
> 
> > I think the various kconfig options should be changed as follows:
> >
> > 1. Only PTP_1588_CLOCK selects PPS.
> > 2. Nothing depends on EXPERIMENTAL.  (This stuff has been in for 18
> >    months and it's even being backported to RHEL 6 now.)
> > 3. Either:
> >    (a) The per-driver PHC options select nothing, and the driver options
> >        do e.g.:
> > 	select PTP_1588_CLOCK if IGB_PTP
> >    (b) The per-driver PHC options are removed and the driver options do:
> > 	select PTP_1588_CLOCK
> >        (i.e. PHC support is unconditional)
> >
> > Any objections to this, or preference for (a) vs (b)?
> 
> No objections, prefer (b).

No objections here, I also prefer (b). The feature shouldn't have much impact unless enabled via hwtstamp_ioctl, and it drastically reduces requirement on end-user needing to enable PHC support.

- Jake

> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html