lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 16 Oct 2012 14:26:47 -0700 From: Tony Lindgren <tony@...mide.com> To: Jon Hunter <jon-hunter@...com> Cc: Richard Cochran <richardcochran@...il.com>, Afzal Mohammed <afzal@...com>, Russell King <linux@....linux.org.uk>, Arnd Bergmann <arnd@...db.de>, netdev@...r.kernel.org, "hvaibhav@...com" <hvaibhav@...com>, David Miller <davem@...emloft.net>, linux-arm-kernel@...ts.infradead.org, "linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org> Subject: Re: [PATCH 1/5] ARM: OMAP2+: gpmc: Fix kernel BUG for DT boot mode * Jon Hunter <jon-hunter@...com> [121016 14:00]: > Hi Tony, > > On 10/16/2012 12:48 PM, Tony Lindgren wrote: > > * Richard Cochran <richardcochran@...il.com> [121015 12:18]: > >> From: hvaibhav@...com <hvaibhav@...com> > >> > >> With recent changes in omap gpmc driver code, in case of DT > >> boot mode, where bootloader does not configure gpmc cs space > >> will result into kernel BUG() inside gpmc_mem_init() function, > >> as gpmc cs0 gpmc_config7[0].csvalid bit is set to '1' and > >> gpmc_config7[0].baseaddress is set to '0' on reset. > >> > >> This use-case is applicable for any board/EVM which doesn't have > >> any peripheral connected to gpmc cs0, for example BeagleXM and > >> BeagleBone, so DT boot mode fails. > >> > >> This patch adds of_have_populated_dt() check before creating > >> device, so that for DT boot mode, gpmc probe will not be called > >> which is expected behavior, as gpmc is not supported yet from DT. > > > > I'm applying this one into omap-for-v3.7-rc1/fixes-part2. > > > > Next time, please also cc linux-omap@...r.kernel.org for series > > like this. I'm sure the people reading the omap list are interested > > in these. > > This patch appears to be masking an underlying issue. How about > something like the following ... OK that looks good to me. I'll drop the earlier fix and use yours instead. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists