netdev - RE: sock_getsockopt() not exported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1350563275.26103.1465.camel@edumazet-glaptop>
Date:	Thu, 18 Oct 2012 14:27:55 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Laight <David.Laight@...LAB.COM>
Cc:	netdev@...r.kernel.org
Subject: RE: sock_getsockopt() not exported

On Thu, 2012-10-18 at 13:03 +0100, David Laight wrote:
> > On Thu, 2012-10-18 at 10:11 +0100, David Laight wrote:
> > > I've noticed that net/core/sock.c contains an
> > >     EXPORT_SYMBOL(sock_setsockopt)
> > > but is missing the corresponding
> > >     EXPORT_SYMBOL(sock_getsockopt)
> > >
> > > In-kernel users of sockets probably manage without
> > > needing to read SOL_SOCKET options.
> > > (They do need to set SO_REUSADDR and SO_KEEPALIVE.)
> > 
> > sock_setsockopt() is exported because sunrpc needs it, and sunrpc can be
> > a module
> > 
> > sock_getsockopt() is not exported because no module needs it yet.
> > 
> > The day one user needs it, we'll add the EXPORT_SYMBOL()
> 
> The problem is that it might be needed by an 'out of tree' driver.
> We already have the function:

We dont care of out of tree drivers.

Thats really simple.

Submit this driver, and add the EXPORT_SYMBOL() you need at that time.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html