netdev - Re: [PATCH] tcp: fix FIONREAD/SIOCINQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20121018.153639.105102863572041684.davem@davemloft.net>
Date:	Thu, 18 Oct 2012 15:36:39 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, enh@...gle.com, ncardwell@...gle.com,
	therbert@...gle.com
Subject: Re: [PATCH] tcp: fix FIONREAD/SIOCINQ

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 18 Oct 2012 21:14:12 +0200

> From: Eric Dumazet <edumazet@...gle.com>
> 
> tcp_ioctl() tries to take into account if tcp socket received a FIN
> to report correct number bytes in receive queue.
> 
> But its flaky because if the application ate the last skb,
> we return 1 instead of 0.
> 
> Correct way to detect that FIN was received is to test SOCK_DONE.
> 
> Reported-by: Elliot Hughes <enh@...gle.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied and queued up for -stable.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html