netdev - RE: [net-next 08/14] igb: Combine post-processing of skb into a single function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AE90C24D6B3A694183C094C60CF0A2F6026B7058@saturn3.aculab.com>
Date:	Fri, 19 Oct 2012 14:49:40 +0100
From:	"David Laight" <David.Laight@...LAB.COM>
To:	"Jeff Kirsher" <jeffrey.t.kirsher@...el.com>, <davem@...emloft.net>
Cc:	"Alexander Duyck" <alexander.h.duyck@...el.com>,
	<netdev@...r.kernel.org>, <gospo@...hat.com>, <sassmann@...hat.com>
Subject: RE: [net-next 08/14] igb: Combine post-processing of skb into a single function

> From: Alexander Duyck <alexander.h.duyck@...el.com>
> 
> This change is meant to just clean-up a number of function calls that were
> made at the end of the Rx clean-up path by combining them into a single
> function call.

Since the functions are static and only called once they
are prime candidates for inlining.
This might happen anyway (depending on the gcc version
and the direction the wind is blowing in).

Marking them with __attribute__((always_inline)) might
be needed to get them actually inlined.

That would maintain the logical separation.

	David



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html