netdev - Re: [PATCH 1/1] [PATCH net-next] net:dev: remove double indentical assignment in dev_change_net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121020000756.GA29345@sergelap>
Date:	Fri, 19 Oct 2012 19:07:56 -0500
From:	Serge Hallyn <serge.hallyn@...onical.com>
To:	Rami Rosen <ramirose@...il.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH 1/1] [PATCH net-next] net:dev: remove double indentical
 assignment in dev_change_net_namespace().

Quoting Rami Rosen (ramirose@...il.com):
> This patch removes double assignment of err to -EINVAL in dev_change_net_namespace().
> 
> Signed-off-by: Rami Rosen <ramirose@...il.com>

Yup, sure is a duplicate assignment...

Acked-by: Serge E. Hallyn <serge.hallyn@...ntu.com>

> ---
>  net/core/dev.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 09cb3f6..b4978e2 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -6264,7 +6264,6 @@ int dev_change_net_namespace(struct net_device *dev, struct net *net, const char
>  		goto out;
>  
>  	/* Ensure the device has been registrered */
> -	err = -EINVAL;
>  	if (dev->reg_state != NETREG_REGISTERED)
>  		goto out;
>  
> -- 
> 1.7.11.4
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html