netdev - Re: 3.5 bridging regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1350827202.13333.2284.camel@edumazet-glaptop>
Date:	Sun, 21 Oct 2012 15:46:42 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Willy Tarreau <w@....eu>
Cc:	Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org
Subject: Re: 3.5 bridging regression

On Sun, 2012-10-21 at 15:26 +0200, Willy Tarreau wrote:
> On Sun, Oct 21, 2012 at 01:53:33PM +0200, Eric Dumazet wrote:
> > Hello Willy
> > 
> > This is most probably the needed fix.
> 
> Good catch, as usual ! It works flawlessly here on top of 3.6.2.
> 
> > I guess David planned to send it to stable teams if not already done.
> 
> Indeed, I've not seen it there yet.
> 
> David, are you OK with sending this patch for -stable ? It fixes
> a 3.5 regression causing bridge to panic.
> 
> > commit acb600def2110b1310466c0e485c0d26299898ae
> > Author: Eric Dumazet <edumazet@...gle.com>
> > Date:   Fri Oct 5 06:23:55 2012 +0000
> > 
> >     net: remove skb recycling
> >     
> >     Over time, skb recycling infrastructure got litle interest and
> >     many bugs. Generic rx path skb allocation is now using page
> >     fragments for efficient GRO / TCP coalescing, and recyling
> >     a tx skb for rx path is not worth the pain.
> 
> Thanks and have a nice week-end !
> Willy
> 

Thanks for testing, sorry for adding a bug.

skb_recycle() was losing skb->head_frag status.

(we could have added some logic in skb_is_recycleable(), but this
function was becoming really too complex)




--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html