netdev - Re: [Pv-drivers] 3.7-rc2 regression : file copied to CIFS-mounted directory corrupted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1351000246.8609.1926.camel@edumazet-glaptop>
Date:	Tue, 23 Oct 2012 15:50:46 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Shreyas Bhatewara <sbhatewara@...are.com>
Cc:	"VMware, Inc." <pv-drivers@...are.com>, netdev@...r.kernel.org,
	edumazet@...gle.com, linux-kernel@...r.kernel.org,
	jongman heo <jongman.heo@...sung.com>
Subject: Re: [Pv-drivers] 3.7-rc2 regression : file copied to CIFS-mounted
 directory corrupted

On Tue, 2012-10-23 at 03:02 -0700, Shreyas Bhatewara wrote:

Please dont top post on netdev or lkml

> Well, actually the driver does split large frags into frags of VMXNET3_MAX_TX_BUF_SIZE bytes each.
> 
> vmxnet3_drv.c
>  711         while (len) {
>  712                 u32 buf_size;
>  713
>  714                 if (len < VMXNET3_MAX_TX_BUF_SIZE) {
>  715                         buf_size = len;
>  716                         dw2 |= len;
>  717                 } else {
>  718                         buf_size = VMXNET3_MAX_TX_BUF_SIZE;
>  719                         /* spec says that for TxDesc.len, 0 == 2^14 */
>  720                 }
>  721
> ....
>  743
>  744                 len -= buf_size;
>  745                 buf_offset += buf_size;
>  746         }

Only the skb head is handled in the code you copy/pasted.

You need to generalize that to code in lines ~754


Then, the number of estimated descriptors is bad :

/* conservatively estimate # of descriptors to use */
count = VMXNET3_TXD_NEEDED(skb_headlen(skb)) +
	skb_shinfo(skb)->nr_frags + 1;


Yes, you need a more precise estimation and vmxnet3_map_pkt() should
eventually split too big frags.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html