netdev - Re: Bug#690845: ethtool: incorrect WoL detection on Broadcom NX II rev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1350956707.5283.48.camel@deadeye.wl.decadent.org.uk>
Date:	Tue, 23 Oct 2012 02:45:07 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Michael Chan <mchan@...adcom.com>, 690845@...s.debian.org
Cc:	Teodor MICU <mteodor@...il.com>, netdev <netdev@...r.kernel.org>
Subject: Re: Bug#690845: ethtool: incorrect WoL detection on Broadcom NX II
 rev < 12

On Mon, 2012-10-22 at 15:54 -0700, Michael Chan wrote:
> On Mon, 2012-10-22 at 10:52 +0300, Teodor MICU wrote:
> > 08:00.0 Ethernet controller: Broadcom Corporation NetXtreme II BCM5708
> > Gigabit Ethernet (rev 11)
> 
> It is 5708 B1, and due to some hardware limitations, ethtool initiated
> WoL is not supported.
[...]

Well we knew that much!  Is the problem that the system firmware 'owns'
the WoL control registers so the host can't safely change them?  Is it
possible to *read* the WoL configuration, if not to change it?

(If even that is not possible, the correct thing to do might be for
ETHTOOL_GWOL to return 'don't know' (EOPNOTSUPP) for this device.  But
since ethtool_ops::get_wol (and various other operations) can't return
an error, that would require you to define a separate instance of
ethtool_ops with get_wol = NULL.  I should look at fixing that...)

Ben.

-- 
Ben Hutchings
Humour is the best antidote to reality.

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)