netdev - RE: [PATCH v3 1/4] net/macb: fix truncate warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AE90C24D6B3A694183C094C60CF0A2F6026B705B@saturn3.aculab.com>
Date:	Tue, 23 Oct 2012 09:21:11 +0100
From:	"David Laight" <David.Laight@...LAB.COM>
To:	"Joachim Eastwood" <manabian@...il.com>, <nicolas.ferre@...el.com>,
	<davem@...emloft.net>, <hskinnemoen@...il.com>,
	<egtvedt@...fundet.no>, <plagnioj@...osoft.com>,
	<bgat@...lgatliff.com>
Cc:	<netdev@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH v3 1/4] net/macb: fix truncate warnings

> When building macb on x86_64 the following warnings show up:
>   drivers/net/ethernet/cadence/macb.c: In function macb_interrupt:
>   drivers/net/ethernet/cadence/macb.c:556:4: warning: large integer implicitly truncated to unsigned type [-Woverflow]
...
> -			macb_writel(bp, IDR, ~0UL);
> +			macb_writel(bp, IDR, -1);

Seems wrong to fix an error with an unsigned value
by using -1.

	David



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html