netdev - ipv4 gro receive IHL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20121022.234606.1841113825492366676.davem@davemloft.net>
Date:	Mon, 22 Oct 2012 23:46:06 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	edumazet@...gle.com
CC:	netdev@...r.kernel.org
Subject: ipv4 gro receive IHL

Eric why do we force the length field to '5' in the ip_fast_csum()
call of inet_gro_receive()?  This happened as part of commit
a9e050f4e7f9d36afe0dcc0bddba864ee442715e ("net: tcp: GRO should be ECN
friendly")

This will cause the checksum check to fail for any IPV4 header with
options.

If that's intended, the way to do this is to reject by checking the
iph->ihl value, rather than doing so obscurely via the checksum call.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html