[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20121024200525.GB6347@electric-eye.fr.zoreil.com>
Date: Wed, 24 Oct 2012 22:05:25 +0200
From: Francois Romieu <romieu@...zoreil.com>
To: hayeswang <hayeswang@...ltek.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 1/2] r8169: enable ALDPS for power saving
hayeswang <hayeswang@...ltek.com> :
> Francois Romieu [mailto:romieu@...zoreil.com]
> [...]
> > It would be nice to state these things in the commit message, namely:
> > - ALDPS should never be enabled for the RTL8105e
> > - none of the firmware-free chipsets support ALDPS
> > - neither do the RTL8168d/8111d
>
> Excuse me. I don't understand why the RTL8105e shouldn't enable ALDPS.
I'd appreciate to see such a statement if ALDPS can be enabled with the
RTL8105e !
You have sent ALDPS related patches for some specific chipsets. Now
would be a sensible time to check if ALDPS is correctly handled for
_all_ supported chipsets. I don't have access to your authoritative
resources. I can only outline something strange in the code wrt
ALDPS and the 8105e.
/me returns to 8169b RxOverflow oddities...
--
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists