lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20121025184252.GC15105@hmsreliant.think-freely.org> Date: Thu, 25 Oct 2012 14:42:52 -0400 From: Neil Horman <nhorman@...driver.com> To: Daniel Wagner <wagi@...om.org> Cc: netdev@...r.kernel.org, cgroups@...r.kernel.org, Daniel Wagner <daniel.wagner@...-carit.de>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Glauber Costa <glommer@...allels.com>, Li Zefan <lizefan@...wei.com>, "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>, Tejun Heo <tj@...nel.org> Subject: Re: [PATCH v1 3/5] cgroup: net_cls: Remove rcu_read_lock/unlock On Thu, Oct 25, 2012 at 04:16:57PM +0200, Daniel Wagner wrote: > From: Daniel Wagner <daniel.wagner@...-carit.de> > > As Eric pointed out: > "Hey task_cls_classid() has its own rcu protection since commit > 3fb5a991916091a908d (cls_cgroup: Fix rcu lockdep warning) > > So we can safely revert Paul commit (1144182a8757f2a1) > (We no longer need rcu_read_lock/unlock here)" > > Signed-off-by: Daniel Wagner <daniel.wagner@...-carit.de> > Cc: "David S. Miller" <davem@...emloft.net> > Cc: Eric Dumazet <edumazet@...gle.com> > Cc: Glauber Costa <glommer@...allels.com> > Cc: Li Zefan <lizefan@...wei.com> > Cc: Neil Horman <nhorman@...driver.com> > Cc: Paul E. McKenney <paulmck@...ux.vnet.ibm.com> > Cc: Tejun Heo <tj@...nel.org> > Cc: netdev@...r.kernel.org > Cc: cgroups@...r.kernel.org > --- > net/core/sock.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/net/core/sock.c b/net/core/sock.c > index c49412c..9fedbbf 100644 > --- a/net/core/sock.c > +++ b/net/core/sock.c > @@ -1221,9 +1221,7 @@ void sock_update_classid(struct sock *sk) > { > u32 classid; > > - rcu_read_lock(); /* doing current task, which cannot vanish. */ > classid = task_cls_classid(current); > - rcu_read_unlock(); > if (classid != sk->sk_classid) > sk->sk_classid = classid; > } > -- > 1.8.0.rc0 > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Acked-by: Neil Horman <nhorman@...driver.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists