netdev - Re: [PATCH] netlink: get rid of the useless function of nlmsg_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20121025.154453.851955498748796353.davem@davemloft.net>
Date:	Thu, 25 Oct 2012 15:44:53 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	zhanghonghui@...wei.com
Cc:	kuznet@....inr.ac.ru, jmorris@...ei.org, lizefan@...wei.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] netlink: get rid of the useless function of
 nlmsg_get_pos()

From: <zhanghonghui@...wei.com>
Date: Thu, 25 Oct 2012 18:00:08 +0800

> From: Hans Zhang <zhanghonghui@...wei.com>
> 
> This function just report the pointer of skb->tail, and there's only
> one use in the kernel.
> 
> Signed-off-by: Hans Zhang <zhanghonghui@...wei.com>

I'm not applying this.

It is obviously useful to somebody, otherwise you wouldn't need
to do anything other than remove the implementation.

It provides an implicit cast, and in that sense it's useful.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html