netdev - Re: [PATCH 1/4] net: mvneta: driver for Marvell Armada 370/XP network unit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121025082106.4041f340@skate>
Date:	Thu, 25 Oct 2012 08:21:06 +0200
From:	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
To:	David Miller <davem@...emloft.net>
Cc:	kernel@...tstofly.org, netdev@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, jason@...edaemon.net,
	andrew@...n.ch, gregory.clement@...e-electrons.com,
	alior@...vell.com, maen@...vell.com
Subject: Re: [PATCH 1/4] net: mvneta: driver for Marvell Armada 370/XP
 network unit

David,

On Wed, 24 Oct 2012 23:06:48 -0400 (EDT), David Miller wrote:
> From: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
> Date: Tue, 23 Oct 2012 18:54:57 +0200
> 
> > +	u32 cause_rx_tx[CONFIG_NR_CPUS];
> 
> Please use per-cpu variables instead of explicitly sized
> arrays.

Ok, thanks. In fact, this per-cpu array is not needed in the current
version of the driver, it will only be needed when we make improvements
to it that bind RX queues to specific CPUs. So for now, I'll get rid of
it.

I'll wait a bit more to see if there are any comments, and I'll repost
an updated v4 of the patches.

Thanks a lot for your review,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html