netdev - Re: [PATCH net-next 00/15] 6lowpan: Some more bug fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5089566D.6000801@signal11.us>
Date:	Thu, 25 Oct 2012 11:10:37 -0400
From:	Alan Ott <alan@...nal11.us>
To:	Tony Cheneau <tony.cheneau@...esiak.org>
CC:	Alexander Smirnov <alex.bluesman.smirnov@...il.com>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-zigbee-devel@...ts.sourceforge.net
Subject: Re: [PATCH net-next 00/15] 6lowpan: Some more bug fixes

On 10/25/2012 10:49 AM, Tony Cheneau wrote:
>  I'm not so OK with removing patch 15, or at least, it would require
> some more testing in other parts of the code. Basically, the TBD are
> placeholder for when the Association Request/Response will be
> reimplemented. I introduced it because otherwise, .assoc_req and
> .assoc_resp entries of mac802154_mlme_wpan would go uninitialized and
> would cause kernel crash when called. I could have modified the
> calling code to deal with that, but I thought these primitives were
> meant to be re-implemented soon anyway.

I think just simply stating this in the commit message would fix the
issue here. Maybe something like "Fix crash where assoc_req() and
assoc_resp() were not defined."

This should probably get split into two patches, one for BSN and the
other for assoc.

Also, make the bsn functions static, and the convention is to put static
functions above where they are being used, so that you don't have to
forward declare them. It looks though, like this source file doesn't do
that for other functions, so maybe following the convention of this file
for now is ok.

Alan.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html