lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1351187513.2662.9.camel@bwh-desktop.uk.solarflarecom.com> Date: Thu, 25 Oct 2012 18:51:53 +0100 From: Ben Hutchings <bhutchings@...arflare.com> To: Chris Metcalf <cmetcalf@...era.com> CC: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] tilegx: fix some issues in the SW TSO support On Thu, 2012-10-25 at 13:25 -0400, Chris Metcalf wrote: > This change correctly computes the header length and data length in > the fragments to avoid a bug where we would end up with extremely > slow performance. Also adopt use of skb_frag_size() accessor. [...] By the way, since you're doing soft-TSO you should probably set net_device::gso_max_segs, as explained in: commit 30b678d844af3305cda5953467005cebb5d7b687 Author: Ben Hutchings <bhutchings@...arflare.com> Date: Mon Jul 30 15:57:00 2012 +0000 net: Allow driver to limit number of GSO segments per skb Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists