netdev - Re: [PATCH] net: usb: Fix memory leak on Tx data path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 26 Oct 2012 09:39:16 +0200
From:	Oliver Neukum <oneukum@...e.de>
To:	Hemant Kumar <hemantk@...eaurora.org>
Cc:	gregkh@...uxfoundation.org, netdev@...r.kernel.org,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH] net: usb: Fix memory leak on Tx data path

On Thursday 25 October 2012 21:17:54 Hemant Kumar wrote:
> Driver anchors the tx urbs and defers the urb submission if
> a transmit request comes when the interface is suspended.
> Anchoring urb increments the urb reference count. These
> deferred urbs are later accessed by calling usb_get_from_anchor()
> for submission during interface resume. usb_get_from_anchor()
> unanchors the urb but urb reference count remains same.
> This causes the urb reference count to remain non-zero
> after usb_free_urb() gets called and urb never gets freed.
> Hence call usb_put_urb() after anchoring the urb to properly
> balance the reference count for these deferred urbs. Also,
> unanchor these deferred urbs during disconnect, to free them
> up.

Good catch. This needs to go into stable, too.
> 
> Signed-off-by: Hemant Kumar <hemantk@...eaurora.org>
Acked-by: Oliver Neukum <oneukum@...e.de>

	Regards
		Oliver

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html