netdev - Re: [PATCH net-next 1/1] tcp: Prevent needless syn-ack rexmt during TWHS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADVnQynogLLze3B3PqUpKf-mZf3NobHXrfpZdPEc7Kbtxcd0NA@mail.gmail.com>
Date:	Thu, 25 Oct 2012 23:31:46 -0400
From:	Neal Cardwell <ncardwell@...gle.com>
To:	Vijay Subramanian <subramanian.vijay@...il.com>
Cc:	Netdev <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Venkat Venkatsubra <venkat.x.venkatsubra@...cle.com>,
	Elliot Hughes <enh@...gle.com>,
	Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net-next 1/1] tcp: Prevent needless syn-ack rexmt during TWHS

On Thu, Oct 25, 2012 at 8:45 PM, Vijay Subramanian
<subramanian.vijay@...il.com> wrote:
> If server socket is slow to accept() connections, request_socks can represent
> connections for which the three-way handshake is already done.  From client's
> point of view, the connection is in ESTABLISHED state but on server side, socket
> is not in accept_queue or ESTABLISHED state.  When the syn-ack timer expires,
> because of the order in which tests are performed, server can retransmit the
> synack repeatedly. Following patch prevents the server from retransmitting the
> synack needlessly (and prevents client from replying with ack).  This reduces
> traffic when server is slow to accept() connections.
>
> If the server socket has received the third ack during connection establishment,
> this is remembered in inet_rsk(req)->acked.  The request_sock will expire in
> around 30 seconds and will be dropped if it does not move into accept_queue.
>
> With help from Eric Dumazet.
>
> Reported-by: Elliot Hughes <enh@...gle.com>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Vijay Subramanian <subramanian.vijay@...il.com>
> ---

Acked-by: Neal Cardwell <ncardwell@...gle.com>
Tested-by: Neal Cardwell <ncardwell@...gle.com>

Nice. Verified the bug and the fix.

neal
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html