netdev - RE: [net-next 10/14] ixgbevf: make sure probe fails on MSI-X enable error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 26 Oct 2012 12:43:12 +0000
From:	"Kicinski, Jakub" <jakub.kicinski@...el.com>
To:	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"davem@...emloft.net" <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>
Subject: RE: [net-next 10/14] ixgbevf: make sure probe fails on MSI-X enable
 error

> From: Jakub Kicinski <jakub.kicinski@...el.com>
> 
> This driver cannot work without MSI-X interrupts so there is no mechanism to
> fall back to.
> 
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...el.com>
> Acked-by: Greg Rose <gregory.v.rose@...el.com>
> Tested-by: Sibai Li <sibai.li@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> ---
>  drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 24 +++++++++++------------
>  1 file changed, 11 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> index b5979ba..7ceccff 100644
> --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
[...]
> @@ -1858,7 +1856,7 @@ static int ixgbevf_set_interrupt_capability(struct
> ixgbevf_adapter *adapter)
>  	for (vector = 0; vector < v_budget; vector++)
>  		adapter->msix_entries[vector].entry = vector;
> 
> -	ixgbevf_acquire_msix_vectors(adapter, v_budget);
> +	err = ixgbevf_acquire_msix_vectors(adapter, v_budget);
> 
>  	err = netif_set_real_num_tx_queues(netdev, adapter->num_tx_queues);
>  	if (err)

This is clearly wrong. My change was overtaken by:

commit 91e2b89b04d3f568dc4ec99f242a4a742061e399
Author: Greg Rose <gregory.v.rose@...el.com>
Date:   Wed Oct 3 00:57:23 2012 +0000

    ixgbevf: Set the netdev number of Tx queues

Please drop this patch, I'll resend a fixed version to Greg.

   -- Kuba
---------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
z siedziba w Gdansku
ul. Slowackiego 173
80-298 Gdansk

Sad Rejonowy Gdansk Polnoc w Gdansku, 
VII Wydzial Gospodarczy Krajowego Rejestru Sadowego, 
numer KRS 101882

NIP 957-07-52-316
Kapital zakladowy 200.000 zl

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html