netdev - Re: [RFC PATCH net-next] pktgen: clean up ktime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD6jFURDrz+SsVcx3E3RnUCY8p7FQzot6Dvpi-mDG2MCVQiEdA@mail.gmail.com>
Date:	Sun, 28 Oct 2012 19:17:11 +0100
From:	Daniel Borkmann <danborkmann@...earbox.net>
To:	Cong Wang <xiyou.wangcong@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [RFC PATCH net-next] pktgen: clean up ktime_t helpers

On Sun, Oct 28, 2012 at 3:31 PM, Cong Wang <xiyou.wangcong@...il.com> wrote:
> On Fri, 26 Oct 2012 at 11:42 GMT, Daniel Borkmann <dxchgb@...il.com> wrote:
>> Some years ago, the ktime_t helper functions ktime_now() and ktime_lt()
>> have been introduced. Instead of defining them inside pktgen.c, they
>> should either use ktime_t library functions or, if not available, they
>> should be defined in ktime.h, so that also others can benefit from them.
>> ktime_compare() is introduced with a similar notion as in timespec_compare().
>>
>> Signed-off-by: Daniel Borkmann <daniel.borkmann@....ee.ethz.ch>
>
> Looks good. This is a cleanup patch, doesn't need to be RFC, I think.

Thanks for the review, I'll resubmit it normally as non-RFC.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html