lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 29 Oct 2012 09:04:03 -0400 From: Mathieu Desnoyers <mathieu.desnoyers@...icios.com> To: Sasha Levin <levinsasha928@...il.com> Cc: torvalds@...ux-foundation.org, tj@...nel.org, akpm@...ux-foundation.org, linux-kernel@...r.kernel.org, linux-mm@...ck.org, paul.gortmaker@...driver.com, davem@...emloft.net, rostedt@...dmis.org, mingo@...e.hu, ebiederm@...ssion.com, aarcange@...hat.com, ericvh@...il.com, netdev@...r.kernel.org, josh@...htriplett.org, eric.dumazet@...il.com, axboe@...nel.dk, agk@...hat.com, dm-devel@...hat.com, neilb@...e.de, ccaulfie@...hat.com, teigland@...hat.com, Trond.Myklebust@...app.com, bfields@...ldses.org, fweisbec@...il.com, jesse@...ira.com, venkat.x.venkatsubra@...cle.com, ejt@...hat.com, snitzer@...hat.com, edumazet@...gle.com, linux-nfs@...r.kernel.org, dev@...nvswitch.org, rds-devel@....oracle.com, lw@...fujitsu.com Subject: Re: [PATCH v7 11/16] net,l2tp: use new hashtable implementation * Sasha Levin (levinsasha928@...il.com) wrote: [...] > -/* Session hash global list for L2TPv3. > - * The session_id SHOULD be random according to RFC3931, but several > - * L2TP implementations use incrementing session_ids. So we do a real > - * hash on the session_id, rather than a simple bitmask. > - */ > -static inline struct hlist_head * > -l2tp_session_id_hash_2(struct l2tp_net *pn, u32 session_id) > -{ > - return &pn->l2tp_session_hlist[hash_32(session_id, L2TP_HASH_BITS_2)]; > - > -} I understand that you removed this hash function, as well as "l2tp_session_id_hash" below, but is there any way we could leave those comments in place ? They look useful. > -/* Session hash list. > - * The session_id SHOULD be random according to RFC2661, but several > - * L2TP implementations (Cisco and Microsoft) use incrementing > - * session_ids. So we do a real hash on the session_id, rather than a > - * simple bitmask. Ditto. > - */ > -static inline struct hlist_head * > -l2tp_session_id_hash(struct l2tp_tunnel *tunnel, u32 session_id) > -{ > - return &tunnel->session_hlist[hash_32(session_id, L2TP_HASH_BITS)]; > -} > - > /* Lookup a session by id > */ Thanks, Mathieu -- Mathieu Desnoyers Operating System Efficiency R&D Consultant EfficiOS Inc. http://www.efficios.com -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists