netdev - Re: [PATCH 03/16] batman-adv: separate BATADV_ATTR_HIF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121029081340.GA5944@ritirata.org>
Date:	Mon, 29 Oct 2012 09:13:40 +0100
From:	Antonio Quartulli <ordex@...istici.org>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, b.a.t.m.a.n@...ts.open-mesh.org,
	lindner_marek@...oo.de
Subject: Re: [PATCH 03/16] batman-adv: separate BATADV_ATTR_HIF_UINT sysfs
 name from hard-iface variable

Hello David,

On Sun, Oct 28, 2012 at 06:59:27PM -0400, David Miller wrote:
> From: Antonio Quartulli <ordex@...istici.org>
> Date: Sun, 28 Oct 2012 12:17:04 +0100
> 
> > From: Marek Lindner <lindner_marek@...oo.de>
> > 
> > Signed-off-by: Marek Lindner <lindner_marek@...oo.de>
> > Signed-off-by: Antonio Quartulli <ordex@...istici.org>
> > ---
> >  net/batman-adv/sysfs.c | 15 ++++++++-------
> >  1 file changed, 8 insertions(+), 7 deletions(-)
> 
> I was wondering how you could possibly change the list of arguments to
> these macros, yet avoid changing any of the users.
> 
> And sure enough it's because these macros are completely unused.

when this macro was introduced a user was going to be added as well, but then we
delayed some work and the user was not introduced anymore..

> 
> Please just remove them instead of changing their interfaces when no
> users exist.

Yes, I will resend the pull request with a patch that removes this macro at all.
We will re-introduce it as soon as the user is ready too.


Cheers,

-- 
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara

Content of type "application/pgp-signature" skipped