netdev - Re: [uclinux-dist-devel] [PATCH RFC net-next 2/4] bfin_mac: replace sys time stamps with raw ones instead.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121030134112.GB2283@netboy.at.omicron.at>
Date:	Tue, 30 Oct 2012 14:41:12 +0100
From:	Richard Cochran <richardcochran@...il.com>
To:	Bob Liu <lliubbo@...il.com>
Cc:	netdev@...r.kernel.org, Miroslav Lichvar <mlichvar@...hat.com>,
	John Ronciak <john.ronciak@...el.com>,
	John Stultz <john.stultz@...aro.org>,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	device-drivers-devel@...ckfin.uclinux.org,
	Jacob Keller <jacob.e.keller@...el.com>,
	uclinux-dist-devel@...ckfin.uclinux.org,
	Patrick Ohly <patrick.ohly@...el.com>,
	David Miller <davem@...emloft.net>
Subject: Re: [uclinux-dist-devel] [PATCH RFC net-next 2/4] bfin_mac:
 replace sys time stamps with raw ones instead.

On Tue, Oct 30, 2012 at 05:17:51PM +0800, Bob Liu wrote:

> > @@ -892,51 +879,25 @@ static void bfin_rx_hwtstamp(struct net_device *netdev, struct sk_buff *skb)
> >
> >         regval = bfin_read_EMAC_PTP_RXSNAPLO();
> >         regval |= (u64)bfin_read_EMAC_PTP_RXSNAPHI() << 32;
> > -       ns = timecounter_cyc2time(&lp->clock, regval);
> > -       timecompare_update(&lp->compare, ns);
> > +       ns = regval >> lp->shift;
> >         memset(shhwtstamps, 0, sizeof(*shhwtstamps));
> >         shhwtstamps->hwtstamp = ns_to_ktime(ns);
> > -       shhwtstamps->syststamp = timecompare_transform(&lp->compare, ns);
> > -
> > -       bfin_dump_hwtamp("RX", &shhwtstamps->hwtstamp, &shhwtstamps->syststamp, &lp->compare);
> > -}
> 
> In my test,  system time in slave side can't be updated although here
> have set shhwtstamps->hwtstamp = ns_to_ktime(ns).
> Any idea?

So the "system time" in shhwtstamps->syststamp has been removed. Only
the raw value remains.

Or what do you mean by "can't be updated"?

How did you test this?

I would suggest the following:

1. test using Documentation/ptp/testptp to make sure the clock is
   working reasconably.

2. try ptp4l from http://linuxptp.sourceforge.net/ to make sure the
   time stamping is working

Thanks,
Richard
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html