netdev - Re: [PATCH 3/4] arm: mvebu: add Ethernet controllers using mvneta driver for Armada 370/XP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABMQnVKswTJr9Nd4Etx4Htv0Ckn+pDNqGO8MoPBH-x8y6CwZyA@mail.gmail.com>
Date:	Tue, 30 Oct 2012 13:19:15 +0900
From:	Nobuhiro Iwamatsu <iwamatsu@...auri.org>
To:	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Lennert Buytenhek <kernel@...tstofly.org>,
	Lior Amsalem <alior@...vell.com>, Andrew Lunn <andrew@...n.ch>,
	Jason Cooper <jason@...edaemon.net>, netdev@...r.kernel.org,
	Maen Suleiman <maen@...vell.com>,
	Gregory Clement <gregory.clement@...e-electrons.com>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 3/4] arm: mvebu: add Ethernet controllers using mvneta
 driver for Armada 370/XP

On Fri, Oct 26, 2012 at 7:03 PM, Thomas Petazzoni
<thomas.petazzoni@...e-electrons.com> wrote:
> The Armada 370 SoC has two network units, while the Armada XP has four
> network units. The first two network units are common to both the
> Armada XP and Armada 370, so they are added to armada-370-xp.dtsi,
> while the other two network units are specific to the Armada XP and
> therefore added to armada-xp.dtsi.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
> ---
>  arch/arm/boot/dts/armada-370-xp.dtsi |   14 ++++++++++++++
>  arch/arm/boot/dts/armada-xp.dtsi     |   14 ++++++++++++++
>  2 files changed, 28 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-370-xp.dtsi b/arch/arm/boot/dts/armada-370-xp.dtsi
> index 16cc82c..d484492 100644
> --- a/arch/arm/boot/dts/armada-370-xp.dtsi
> +++ b/arch/arm/boot/dts/armada-370-xp.dtsi
> @@ -68,6 +68,20 @@
>                         compatible = "marvell,armada-addr-decoding-controller";
>                         reg = <0xd0020000 0x258>;
>                 };
> +
> +                ethernet@...70000 {
> +                               compatible = "marvell,armada-370-neta";
> +                               reg = <0xd0070000 0x2500>;
> +                               interrupts = <8>;
> +                               status = "disabled";
> +                };
> +
> +                ethernet@...74000 {
> +                               compatible = "marvell,armada-370-neta";
> +                               reg = <0xd0074000 0x2500>;
> +                               interrupts = <10>;
> +                               status = "disabled";
> +                };

Could you fit an indent?

>         };
>  };
>
> diff --git a/arch/arm/boot/dts/armada-xp.dtsi b/arch/arm/boot/dts/armada-xp.dtsi
> index 71d6b5d..c77a43e 100644
> --- a/arch/arm/boot/dts/armada-xp.dtsi
> +++ b/arch/arm/boot/dts/armada-xp.dtsi
> @@ -51,5 +51,19 @@
>                                 compatible = "marvell,armada-370-xp-system-controller";
>                                 reg = <0xd0018200 0x500>;
>                 };
> +
> +                ethernet@...30000 {
> +                               compatible = "marvell,armada-370-neta";
> +                               reg = <0xd0030000 0x2500>;
> +                               interrupts = <12>;
> +                               status = "disabled";
> +                };
> +
> +                ethernet@...34000 {
> +                               compatible = "marvell,armada-370-neta";
> +                               reg = <0xd0034000 0x2500>;
> +                               interrupts = <14>;
> +                               status = "disabled";
> +                };

likewise.

-- 
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org}
   GPG ID: 40AD1FA6
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html