lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20121031075743.GA2327@netboy.at.omicron.at> Date: Wed, 31 Oct 2012 08:57:43 +0100 From: Richard Cochran <richardcochran@...il.com> To: Bob Liu <lliubbo@...il.com> Cc: netdev@...r.kernel.org, Miroslav Lichvar <mlichvar@...hat.com>, John Ronciak <john.ronciak@...el.com>, John Stultz <john.stultz@...aro.org>, Jeff Kirsher <jeffrey.t.kirsher@...el.com>, device-drivers-devel@...ckfin.uclinux.org, Jacob Keller <jacob.e.keller@...el.com>, uclinux-dist-devel@...ckfin.uclinux.org, Patrick Ohly <patrick.ohly@...el.com>, David Miller <davem@...emloft.net> Subject: Re: [uclinux-dist-devel] [PATCH RFC net-next 2/4] bfin_mac: replace sys time stamps with raw ones instead. On Wed, Oct 31, 2012 at 02:47:21PM +0800, Bob Liu wrote: > > @@ -861,15 +854,9 @@ static void bfin_tx_hwtstamp(struct net_device *netdev, struct sk_buff *skb) > > regval = bfin_read_EMAC_PTP_TXSNAPLO(); > > regval |= (u64)bfin_read_EMAC_PTP_TXSNAPHI() << 32; > > memset(&shhwtstamps, 0, sizeof(shhwtstamps)); > > - ns = timecounter_cyc2time(&lp->clock, > > - regval); > > - timecompare_update(&lp->compare, ns); > > + ns = regval >> lp->shift; > > Why not set ns = regval << lp->shift? > I think it's conflicted with patch [3/4] Yes, you are right. I will fix this in V2. > > @@ -892,51 +879,25 @@ static void bfin_rx_hwtstamp(struct net_device *netdev, struct sk_buff *skb) > > > > regval = bfin_read_EMAC_PTP_RXSNAPLO(); > > regval |= (u64)bfin_read_EMAC_PTP_RXSNAPHI() << 32; > > - ns = timecounter_cyc2time(&lp->clock, regval); > > - timecompare_update(&lp->compare, ns); > > + ns = regval >> lp->shift; > > So is here. Thanks for the careful review, Richard -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists