netdev - RE: [PATCH v8 01/16] hashtable: introduce a small and naive hashtable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AE90C24D6B3A694183C094C60CF0A2F6026B7080@saturn3.aculab.com>
Date:	Wed, 31 Oct 2012 09:46:20 -0000
From:	"David Laight" <David.Laight@...LAB.COM>
To:	"Steven Rostedt" <rostedt@...dmis.org>,
	"Sasha Levin" <levinsasha928@...il.com>
Cc:	"Tejun Heo" <tj@...nel.org>, <torvalds@...ux-foundation.org>,
	<akpm@...ux-foundation.org>, <linux-kernel@...r.kernel.org>,
	<linux-mm@...ck.org>, <paul.gortmaker@...driver.com>,
	<davem@...emloft.net>, <mingo@...e.hu>, <ebiederm@...ssion.com>,
	<aarcange@...hat.com>, <ericvh@...il.com>,
	<netdev@...r.kernel.org>, <josh@...htriplett.org>,
	<eric.dumazet@...il.com>, <mathieu.desnoyers@...icios.com>,
	<axboe@...nel.dk>, <agk@...hat.com>, <dm-devel@...hat.com>,
	<neilb@...e.de>, <ccaulfie@...hat.com>, <teigland@...hat.com>,
	<Trond.Myklebust@...app.com>, <bfields@...ldses.org>,
	<fweisbec@...il.com>, <jesse@...ira.com>,
	<venkat.x.venkatsubra@...cle.com>, <ejt@...hat.com>,
	<snitzer@...hat.com>, <edumazet@...gle.com>,
	<linux-nfs@...r.kernel.org>, <dev@...nvswitch.org>,
	<rds-devel@....oracle.com>, <lw@...fujitsu.com>
Subject: RE: [PATCH v8 01/16] hashtable: introduce a small and naive hashtable

> > > On Tue, Oct 30, 2012 at 02:45:57PM -0400, Sasha Levin wrote:
> > >> +/* Use hash_32 when possible to allow for fast 32bit hashing in 64bit kernels. */
> > >> +#define hash_min(val, bits)                                                  \
> > >> +({                                                                           \
> > >> +     sizeof(val) <= 4 ?                                                      \
> > >> +     hash_32(val, bits) :                                                    \
> > >> +     hash_long(val, bits);                                                   \
> > >> +})
> > >
> > > Doesn't the above fit in 80 column.  Why is it broken into multiple
> > > lines?  Also, you probably want () around at least @val.  In general,
> > > it's a good idea to add () around any macro argument to avoid nasty
> > > surprises.
> >
> > It was broken to multiple lines because it looks nicer that way (IMO).
> >
> > If we wrap it with () it's going to go over 80, so it's going to stay
> > broken down either way :)
> 
> ({								      \
> 	sizeof(val) <= 4 ? hash_32(val, bits) : hash_long(val, bits); \
> })
> 
> Is the better way to go. We are C programmers, we like to see the ?: on
> a single line if possible. The way you have it, looks like three
> statements run consecutively.

To add some more colour (not color):

In any case, this is a normal C #define, it doesn't need the {}.
So it can just be:
# define hash_min(val, bits) \
	(sizeof(val) <= 4 ? hash_32(val, bits) : hash_long(val, bits))

I don't think that s/val/(val)/g and s/bits/(bits)/g are needed
because the tokens are already ',' separated.

I do actually wonder how many of these hash lists should be replaced
with some kind of tree structure in order to get O(log(n)) searches.
After all hashing is still O(n).
(apologies if I mean o(n) not O(n) - it's a long time since I did
my maths degree!)

	David



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html