netdev - Re: [PATCH net-next v2] packet: tx_ring: allow the user to choose tx data offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20121101.105421.1443685043169389365.davem@davemloft.net>
Date:	Thu, 01 Nov 2012 10:54:21 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	paul.chavent@...c.net
Cc:	Paul.Chavent@...ra.fr, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] packet: tx_ring: allow the user to choose
 tx data offset

From: Paul Chavent <paul.chavent@...c.net>
Date: Wed, 31 Oct 2012 22:22:07 +0100

> It seems that the user can already fire an error msg by simply pass a
> too long tp_len.
> 
> Though, should i remove it from the tpacket_fill_skb function and
> silently return -EINVAL ?

Returning an error is much better than emitting log messages,
always.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html