[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20121101.113701.1219642954944154124.davem@davemloft.net>
Date: Thu, 01 Nov 2012 11:37:01 -0400 (EDT)
From: David Miller <davem@...emloft.net>
To: bhutchings@...arflare.com
Cc: giometti@...eenne.com, richardcochran@...il.com,
netdev@...r.kernel.org, linux-net-drivers@...arflare.com
Subject: Re: [PATCH net-next 0/3] Enable PPS and PTP clocks automatically
From: Ben Hutchings <bhutchings@...arflare.com>
Date: Thu, 1 Nov 2012 01:29:57 +0000
> There are a number of problems with PPS and PTP kconfig options:
>
> 1. PPS and PTP_1588_CLOCK depend on EXPERIMENTAL, therefore so must the
> clock drivers. (And EXPERIMENTAL is deprecated.)
> 2. PTP_1588_CLOCK depends on PPS, so users or clock driver options must
> explicitly select both.
> 3. In general, users have to enable too many options to get hardware
> timestamps and PTP working.
> 4. Boolean options for clock drivers combined with net drivers can force
> the PTP and PPS subsystems to be built-in unnecessarily.
>
> This series changes the options as follows:
>
> 1. Nothing depends on EXPERIMENTAL.
> 2. Only PTP_1588_CLOCK selects PPS.
> 3, 4. The boolean options are removed and the net driver options select
> PTP_1588_CLOCK. Where a net driver and associated clock driver are
> separate modules, the clock driver remains optional but is default y.
Looks good, series applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists